zeroshade commented on code in PR #1593: URL: https://github.com/apache/arrow-adbc/pull/1593#discussion_r1530978828
########## go/adbc/driver/snowflake/connection.go: ########## @@ -18,12 +18,14 @@ package snowflake import ( + "cmp" "context" "database/sql" "database/sql/driver" "fmt" "io" "regexp" + "slices" Review Comment: the packages `cmp` and `slices` were only added in `go1.21` so either we need to bump our minimum version or we need to replace the usages of these. @lidavidm what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org