vyasr commented on code in PR #406:
URL: https://github.com/apache/arrow-nanoarrow/pull/406#discussion_r1532413610
##########
CMakeLists.txt:
##########
@@ -154,13 +154,48 @@ else()
endif()
endif()
- install(TARGETS nanoarrow DESTINATION lib)
+ install(TARGETS nanoarrow
+ DESTINATION lib
+ EXPORT nanoarrow-exports)
+ install(TARGETS coverage_config
+ DESTINATION lib
+ EXPORT nanoarrow-exports)
Review Comment:
Also for context @paleolimbot this is how I would anticipate consuming the
components that I suggested in #407. You'd produce an importable nanoarrow that
has targets like `nanoarrow::nanoarrow`, `nanoarrow::coverage_config`,
`nanoarrow::ipc`, `nanoarrow::device`, and then the user could do something
like `find_package(nanoarrow COMPONENTS device)` and then
`target_link_libraries(my_pkg PRIVATE nanoarrow_device)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
