bkietz commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1532533507
##########
arrow-ipc/src/reader.rs:
##########
@@ -79,6 +83,16 @@ fn create_array(reader: &mut ArrayReader, field: &Field) ->
Result<ArrayRef, Arr
reader.next_buffer()?,
],
),
+ BinaryView | Utf8View => {
+ let count = variadic_counts
+ .pop_front()
+ .ok_or(ArrowError::IpcError("Incorrect variadic
count!".to_owned()))?;
Review Comment:
Even if we have some variadic counts we could hit this error if there were
more columns requiring them.
```suggestion
.ok_or(ArrowError::IpcError(format!("Missing variadic count
for {data_type} column")))?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
