bkietz commented on a change in pull request #9294:
URL: https://github.com/apache/arrow/pull/9294#discussion_r573263871
##########
File path: python/pyarrow/tests/parquet/test_dataset.py
##########
@@ -206,7 +206,7 @@ def test_filters_equivalency(tempdir, use_legacy_dataset):
dataset = pq.ParquetDataset(
base_path, filesystem=fs,
filters=[('integer', '=', 1), ('string', '!=', 'b'),
- ('boolean', '==', True)],
+ ('boolean', '==', 'True')],
Review comment:
@jorisvandenbossche Previously we allowed the implicit cast from boolean
to string, but after this PR comparing a column of type string to a boolean
scalar is no longer supported. Column "boolean" has type string because no
explicit schema is provided and it isn't inferred as integral, which leaves
string.
Making matters worse: we *can't* provide an explicit schema because
`_ParquetDatasetV2` doesn't support that kwarg and `ParquetDataset` doesn't
support a custom partitioning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
