tshauck commented on PR #9729: URL: https://github.com/apache/arrow-datafusion/pull/9729#issuecomment-2015642603
@alamb, would you be able to please give me some feedback here? In https://github.com/apache/arrow-datafusion/pull/9729/commits/a7a7808d5a5088540e80308a4c0a0a39a22a899a, I made parser public and added an example, and that seemed to go well insofar as I could create a new `MyStatement` which is an enum of a DF Statement and a custom one. That was good, but then it can't work with df functionality like `sql_statement_to_plan`, so in [86588e4](https://github.com/apache/arrow-datafusion/pull/9729/commits/86588e4513fc787c01c567c40bb76cb598a55ad1) I started down added an Extension enum variant to `Statement`, based on how the LogicalPlan extensions work, but I'm having trouble integrating it into DF writ large... e.g. I'm running into many object safety issues... <img width="916" alt="image" src="https://github.com/apache/arrow-datafusion/assets/421839/d512090f-b2b4-48df-98e0-4c8f6cf2c243";> So I guess my questions are 1) does an Extension statement seem reasonable to you? 2) and if so, any advice on the implementation to mitigate object safety issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
