paleolimbot commented on code in PR #405:
URL: https://github.com/apache/arrow-nanoarrow/pull/405#discussion_r1537735183
##########
CMakeLists.txt:
##########
@@ -18,6 +18,11 @@
message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
cmake_minimum_required(VERSION 3.14)
+# Try to use C11 (required by IPC extension) but fall back to C99
Review Comment:
I removed this...it's mostly just confusing and apparently wasn't necessary.
I did remember that the IPC extension prefers C11 because it (optionally) uses
C11 atomics to implement sharing of buffers. We have a CI check to make sure
that the IPC extension compiles with C99.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
