ianmcook commented on a change in pull request #9423: URL: https://github.com/apache/arrow/pull/9423#discussion_r574628901
########## File path: r/tests/testthat/test-dplyr.R ########## @@ -256,6 +262,29 @@ test_that("filter() with %in%", { ) }) +test_that("filter() with string ops", { + expect_dplyr_equal( + input %>% + filter(dbl > 2, toupper(chr) %in% c("D", "F")) %>% + collect(), + tbl + ) Review comment: This test would pass without the changes in this PR. Do you want to try to test `toupper()` and `tolower()` in a way that would have failed before but succeeds now? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org