BryanCutler commented on pull request #9187: URL: https://github.com/apache/arrow/pull/9187#issuecomment-778506839
@WeichenXu123 we would just need to add the following API to `BaseVariableWidthVector` (and possibly `BaseRepeatedValueVector`) ```Java public int getBufferSizeFor(final int valueCount, double density) ``` The argument `density` is used elsewhere, so we should stick with that to be consistent. Also, the method `public double getDensity()` already exists in `BaseVariableWidthVector`. As for it being static, it could be, but just as the related methods it might be a good idea to not do this in case a subclass would want to override it in the future. Is it a requirement in your use case to be static? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
