praveenbingo commented on a change in pull request #9486:
URL: https://github.com/apache/arrow/pull/9486#discussion_r575663519
##########
File path: cpp/src/gandiva/expr_decomposer.cc
##########
@@ -212,11 +219,16 @@ Status ExprDecomposer::Visit(const LiteralNode& node) {
// that has a match will do it).
// Both of the above optimisations save CPU cycles during expression
evaluation.
-int ExprDecomposer::PushThenEntry(const IfNode& node) {
+int ExprDecomposer::PushThenEntry(const IfNode& node, bool reuse_bitmap) {
int local_bitmap_idx;
- if (!if_entries_stack_.empty() &&
- if_entries_stack_.top()->entry_type_ == kStackEntryElse) {
+ if (reuse_bitmap) {
Review comment:
the comment above this seems off - i am fine if we want to address this
separare
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
