alamb opened a new pull request #9487:
URL: https://github.com/apache/arrow/pull/9487


   NOTE: This is a backwards incompatible change in DataFusion
   
   Inspired by a conversation with @seddonm1  
https://github.com/apache/arrow/pull/9448#discussion_r573289996 and 
https://github.com/apache/arrow/pull/9445 as well as some upcoming needs in IOx 
(a consumer of DataFusion)
   
   # Rationale:
   * No `TableProvider` APIs actually require ownership of the `TableProvider` 
(they all take `&self`)
   * Internally DataFusion was storing the TableProvider as an Arc already and 
inconsistently uses `Box`d and `Arc`d table providers  (e.g. in 
[`LogicalPlan::TableScan`](https://github.com/apache/arrow/blob/437c9173c3e067712eb714c643ca839acc7ed7f6/rust/datafusion/src/logical_plan/plan.rs#L125))
   * This change allows the same `TableProvider` instance to be reused easily 
for different `ExecutionContext`s
   
   # Changes
   * Change all uses of `TableProvider` to be wrapped in `Arc` rather than `Box`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to