Dandandan commented on a change in pull request #9243:
URL: https://github.com/apache/arrow/pull/9243#discussion_r575832238
##########
File path: rust/datafusion/Cargo.toml
##########
@@ -64,6 +64,9 @@ log = "^0.4"
md-5 = "^0.9.1"
sha2 = "^0.9.1"
ordered-float = "2.0"
+unicode-segmentation = "^1.7.1"
Review comment:
FWIW, `regex` / `lazy_static` are already non-optional dependencies of
`arrow`, so I think not that much can be gained there, unless we make it
optional in Arrow as well.
I think it is a good idea to make some features optional, to reduce compile
times whenever you are not working on them.
Another thing we can do to split benchmarks / examples / etc. out of the
crate to make compile times a bit shorter, which I started doing hereL
https://github.com/apache/arrow/pull/9494 and
https://github.com/apache/arrow/pull/9493
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
