alamb commented on issue #9972:
URL:
https://github.com/apache/arrow-datafusion/issues/9972#issuecomment-2041132561
> That indicates that we need reverse_expr for AggregateUDFImpl.
I agree
> Therefore, we need to have reverse_expr for AggregateUDF, and the only
choice for us is self.inner.reverse_expr. That indicates that we need
reverse_expr for AggregateUDFImpl.
I wonder if we could have the function return `AggregateUDF` instead of
`AggregateExpr` ? Something like
```rust
trait AggregateUDFImpl {
...
// fun: AggregateUDF,
fn reverse_expr(&self) -> Option<Arc<dyn AggregateExpr>> {
self.fun.reverse_expr()
}
```
And then we can reconstruct the AggregateExpr from there?
My thinking is that once we have ported all aggregates to AggregateUDF then
this would be the only way to implement Aggregates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
