JasonLi-cn commented on code in PR #9971: URL: https://github.com/apache/arrow-datafusion/pull/9971#discussion_r1554795663
########## datafusion/functions/src/string/common.rs: ########## @@ -103,6 +104,7 @@ pub(crate) fn general_trim<T: OffsetSizeTrait>( /// This function errors when: /// * the number of arguments is not 1 /// * the first argument is not castable to a `GenericStringArray` +#[allow(dead_code)] Review Comment: You are right; this can be removed. I plan to delete these seemingly unnecessary pieces of code after they have been reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
