pitrou commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r576994839
##########
File path: cpp/src/arrow/array/data.cc
##########
@@ -130,6 +130,33 @@ int64_t ArrayData::GetNullCount() const {
return precomputed;
}
+bool ArrayData::Equals(const ArrayData& other) const {
Review comment:
I don't think this is right. Equality is more complicated than that.
Instead of adding this, I would suggest you simply use `MakeArray` in tests
and then call `AssertArraysEqual`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
