tustvold commented on code in PR #5611:
URL: https://github.com/apache/arrow-rs/pull/5611#discussion_r1565636903


##########
arrow-cast/src/parse.rs:
##########
@@ -671,6 +671,126 @@ impl Parser for Date64Type {
     }
 }
 
+fn parse_e_notation<T: DecimalType>(
+    s: &str,
+    mut digits: u16,
+    mut fractionals: i16,
+    mut result: T::Native,
+    index: usize,
+    precision: u16,
+    scale: i16,

Review Comment:
   I wonder if this state could be encapsulated into a struct or similar, 
possibly something for a follow up PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to