huaxingao commented on code in PR #234:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/234#discussion_r1566801330
##########
core/src/execution/proto/expr.proto:
##########
@@ -149,6 +151,20 @@ message BitXorAgg {
DataType datatype = 2;
}
+message CovSample {
+ Expr child1 = 1;
+ Expr child2 = 2;
+ bool null_on_divide_by_zero = 3;
Review Comment:
Right, this is not used yet. I will have a follow up to address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
