westonpace opened a new pull request #9519:
URL: https://github.com/apache/arrow/pull/9519
See issue for rationale / description.
To consider:
* I based licensing text on other vendored libraries but I'm no expert in
how exactly to dot all the i's and cross all the t's.
* The constructor can throw if allocation of the ring buffer fails. In
general, this sort of queue shouldn't be all that large anyways so this seems
unlikely. We could modify the constructor to be private with a factory method
that returns `Result` but at the moment I'm not making any changes to the
existing code and so I'm hesitant to start doing so for this reason.
* There is a test case for the above point but I could take it out if
desired.
* There is a comparative benchmark for boost. I'm not sure if we want to
leave that in?
* I've renamed folly::ProducerConsumerQueue to arrow::util::SpscQueue. I
feel the name ProducerConsumerQueue is too vague and could lead to improper
usage. This queue is not safe for multiple readers or multiple writers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
