alexandreyc commented on code in PR #1725: URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568501581
########## rust2/core/Cargo.toml: ########## @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +name = "adbc_core" +description = "Public abstract API, driver manager and driver exporter" +version = { workspace = true } +edition = { workspace = true } +authors = { workspace = true } +license = { workspace = true } + +[dependencies] +arrow = { workspace = true } +libloading = "0.8" Review Comment: For the moment we need to keep it here because we `impl From<libloading::Error> for Error` in `error.rs`. But this raises an interesting question: how should we structure the workspace? Currently, we have: - A `core` crate that contains traits/structs for the API, the driver manager and the driver exporter - A crate for each driver in `drivers/*` Should we split the driver manager and the driver exporter into different crates? One possible solution: - Move the driver manager to `drivers/` (it's a driver after all) - Keep the driver exporter into the core crate (because it does not introduce any new dependency and it's tightly coupled to the abstract API) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
