abandy commented on code in PR #41342:
URL: https://github.com/apache/arrow/pull/41342#discussion_r1577673357
##########
swift/Arrow/Package.swift:
##########
@@ -36,18 +36,27 @@ let package = Package(
// and therefore doesn't include the unaligned buffer swift changes.
// This can be changed back to using the tag once a new version of
// flatbuffers has been released.
- .package(url: "https://github.com/google/flatbuffers.git";, branch:
"master")
+ .package(url: "https://github.com/google/flatbuffers.git";, branch:
"master"),
+ .package(
+ url: "https://github.com/apple/swift-atomics.git";,
+ .upToNextMajor(from: "1.2.0") // or `.upToNextMinor
+ )
],
targets: [
// Targets are the basic building blocks of a package. A target can
define a module or a test suite.
// Targets can depend on other targets in this package, and on
products in packages this package depends on.
+ .target(
+ name: "ArrowC", // your C/C++ library's name
+ path: "Sources/ArrowC" // your path to the C/C++ library
Review Comment:
Good catch! I will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
