felipecrv commented on code in PR #41366: URL: https://github.com/apache/arrow/pull/41366#discussion_r1578571911
########## cpp/src/arrow/table.cc: ########## @@ -632,6 +633,7 @@ TableBatchReader::TableBatchReader(std::shared_ptr<Table> table) for (int i = 0; i < owned_table_->num_columns(); ++i) { column_data_[i] = owned_table_->column(i).get(); } + ARROW_DCHECK_OK(table_.ValidateFull()); Review Comment: same ########## cpp/src/arrow/table.cc: ########## @@ -619,6 +619,7 @@ TableBatchReader::TableBatchReader(const Table& table) for (int i = 0; i < table.num_columns(); ++i) { column_data_[i] = table.column(i).get(); } + ARROW_DCHECK_OK(table_.ValidateFull()); Review Comment: Please use `DCHECK(table_.Validate().ok());` so it's not validated in all builds. `DCHECK_OK` is weird https://github.com/apache/arrow/blob/192de026ad5c021846d89449757b0ac679436d13/cpp/src/arrow/util/logging.h#L92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org