alamb commented on pull request #9509: URL: https://github.com/apache/arrow/pull/9509#issuecomment-782663789
@seddonm1 we are so close -- now there is a clippy error: https://github.com/apache/arrow/pull/9509/checks?check_run_id=1922005826 ``` ror: this function's return value is unnecessarily wrapped by `Result` --> arrow/src/compute/kernels/length.rs:86:1 | 86 | / fn bit_length_impl<O: StringOffsetSizeTrait, T: ArrowPrimitiveType>( 87 | | array: &dyn Array, 88 | | ) -> Result<ArrayRef> 89 | | where ... | 99 | | })) 100 | | } | |_^ | = note: `-D clippy::unnecessary-wraps` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps help: remove `Result` from the return type... | 88 | ) -> std::sync::Arc<(dyn array::array::Array + 'static)> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: ...and change the returning expressions | 97 | unary_offsets_string::<O, _>(array, T::DATA_TYPE, |x| { 98 | x * bits_in_bytes 99 | }) | error: aborting due to previous error error: could not compile `arrow` To learn more, run the command again with --verbose. warning: build failed, waiting for other jobs to finish... error: this function's return value is unnecessarily wrapped by `Result` --> arrow/src/compute/kernels/length.rs:86:1 | 86 | / fn bit_length_impl<O: StringOffsetSizeTrait, T: ArrowPrimitiveType>( 87 | | array: &dyn Array, 88 | | ) -> Result<ArrayRef> 89 | | where ... | 99 | | })) 100 | | } | |_^ | = note: `-D clippy::unnecessary-wraps` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps help: remove `Result` from the return type... | 88 | ) -> std::sync::Arc<(dyn array::array::Array + 'static)> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: ...and change the returning expressions | 97 | unary_offsets_string::<O, _>(array, T::DATA_TYPE, |x| { 98 | x * bits_in_bytes 99 | }) | ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
