RinChanNOWWW commented on code in PR #5707:
URL: https://github.com/apache/arrow-rs/pull/5707#discussion_r1589866576
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -265,6 +266,115 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
phantom: Default::default(),
}
}
+
+ /// Returns whether the buffers are compact
+ pub(self) fn compact_check(&self) -> Vec<bool> {
Review Comment:
If we just check if the `ByteViewArray` is compacted, we don't need to check
every buffers and collect a `Vec<bool>`.
Just using a short circuit strategy and return `bool` is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
