alamb commented on code in PR #5720:
URL: https://github.com/apache/arrow-rs/pull/5720#discussion_r1590282887
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -265,6 +269,27 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
phantom: Default::default(),
}
}
+
+ // TODO: remove this after GC is implemented
Review Comment:
I don't understand this comment -- I think adding a function to check if the
views are fully compacited is a reasonable feature, and while the main usecase
I can think of would be "should I run gc on this array" I don't understand why
we would remove it after gc 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
