zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594501276


##########
go/arrow/csv/reader.go:
##########
@@ -740,81 +740,67 @@ func (r *Reader) parseDate32(field array.Builder, str 
string) {
        field.(*array.Date32Builder).Append(arrow.Date32FromTime(tm))
 }
 
-func (r *Reader) parseTime32(field array.Builder, str string, unit 
arrow.TimeUnit) {
+func (r *Reader) parseDate64(field array.Builder, str string) {
        if r.isNull(str) {
                field.AppendNull()
                return
        }
 
-       val, err := arrow.Time32FromString(str, unit)
+       tm, err := time.Parse("2006-01-02", str)

Review Comment:
   do we want to allow specifying the date format? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to