adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1596601442
##########
c_glib/arrow-glib/array-builder.h:
##########
@@ -22,70 +22,97 @@
#include <arrow-glib/array.h>
#include <arrow-glib/decimal.h>
#include <arrow-glib/interval.h>
+#include <arrow-glib/visibility.h>
G_BEGIN_DECLS
#define GARROW_TYPE_ARRAY_BUILDER (garrow_array_builder_get_type())
+GARROW_EXPORT
G_DECLARE_DERIVABLE_TYPE(
GArrowArrayBuilder, garrow_array_builder, GARROW, ARRAY_BUILDER, GObject)
struct _GArrowArrayBuilderClass
{
GObjectClass parent_class;
};
+GARROW_EXPORT
GArrowDataType *
garrow_array_builder_get_value_data_type(GArrowArrayBuilder *builder);
+
+GARROW_EXPORT
GArrowType
garrow_array_builder_get_value_type(GArrowArrayBuilder *builder);
+GARROW_EXPORT
GArrowArray *
garrow_array_builder_finish(GArrowArrayBuilder *builder, GError **error);
GARROW_AVAILABLE_IN_2_0
+GARROW_EXPORT
Review Comment:
I thought I could have this PR only change the arrow-glib library and do the
others in a follow up to keep the changes manageable, but the MinGW build fails
with link errors like "redeclared without dllimport attribute after being
referenced with dll linkage", so I might need to add the separated version
macros as part of this PR too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
