zeroshade commented on code in PR #40496:
URL: https://github.com/apache/arrow/pull/40496#discussion_r1598476396
##########
go/arrow/array/dictionary.go:
##########
@@ -672,7 +672,7 @@ func NewDictionaryBuilderWithDict(mem memory.Allocator, dt
*arrow.DictionaryType
}
func NewDictionaryBuilder(mem memory.Allocator, dt *arrow.DictionaryType)
DictionaryBuilder {
- return NewDictionaryBuilderWithDict(mem, dt, nil)
+ return NewDictionaryBuilderWithDict(mem, dt, dt.Values)
Review Comment:
the dictionary builders all have an `InsertDictValues` method which allows
you to insert an array of dictionary values without adding them as indices.
That's probably the best way to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
