WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1602267855


##########
src/nanoarrow/buffer_test.cc:
##########
@@ -141,9 +141,6 @@ TEST(BufferTest, BufferTestFill) {
   }
 
   ArrowBufferReset(&buffer);
-

Review Comment:
   The BufferTestError checks for ENOMEM using `ArrowBufferResize` - do you 
think it would be better to add the `ArrowBufferReserve` test there for 
consistency or do you want to keep within this test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to