tustvold commented on code in PR #5769: URL: https://github.com/apache/arrow-rs/pull/5769#discussion_r1603220808
########## arrow-array/src/types.rs: ########## @@ -264,11 +264,11 @@ Each field is independent (e.g. there is no constraint that the quantity of nanoseconds represents less than a day's worth of time). ```text -┌──────────────────────────────┬─────────────┬──────────────┐ -│ Nanos │ Days │ Months │ -│ (64 bits) │ (32 bits) │ (32 bits) │ -└──────────────────────────────┴─────────────┴──────────────┘ - 0 63 95 127 bit offset +┌───────────────┬─────────────┬─────────────────────────────┐ Review Comment: Yes, and they're now actually testing the logic rather than doing the mapping themselves -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
