hiltontj opened a new pull request, #5782:
URL: https://github.com/apache/arrow-rs/pull/5782
Allows for writing binary (Binary, LargeBinary, and FixedSizeBinary) to CSV.
Note: FixedSizeBinary was already being supported in this way.
Values are encoded as HEX, by using the default Arrow formatter.
A test was added that accounts for null values when encoding all three
binary types in CSV.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3921.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently, `FixedSizeBinary` is encoded in CSV (and JSON) as HEX (see
https://github.com/apache/arrow-rs/issues/3291#issuecomment-2118244809).
Therefore, it seemed reasonable to lift the restriction that was preventing
writing `Binary` and `LargeBinary` arrays.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
The condition that checks if the datatype on the array is `Binary` or
`LargeBinary` was removed, and a test was added to check writing to CSV of the
three binary types: `Binary`, `LargeBinary`, and `FixedSizeBinary`. The test
also checks for null values.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
This will change the behaviour of the writer for users, but should not be a
breaking change, since previously, an error was being thrown when attempting to
write these data types to CSV.
We may need to document that such types are encoded as HEX in the CSV
writer, as they are with the standard Arrow formatter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
