cyb70289 commented on a change in pull request #9435:
URL: https://github.com/apache/arrow/pull/9435#discussion_r580798353
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -1625,6 +1669,10 @@ TEST_F(TestRandomQuantileKernel, Histogram) {
// exercise histogram approach: size >= 65536, range <= 65536
this->CheckQuantiles(/*array_size=*/80000, /*num_quantiles=*/100);
}
+
+TEST_F(TestRandomQuantileKernel, TDigest) {
+ this->CheckTDigests(/*chunk_sizes=*/{12345, 6789, 8765, 4321},
/*num_quantiles=*/100);
Review comment:
Hmm..., only Nulls or NaNs are not checked for TDigest, will add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
