FiV0 commented on code in PR #41731:
URL: https://github.com/apache/arrow/pull/41731#discussion_r1606685465
##########
java/vector/src/test/java/org/apache/arrow/vector/types/pojo/TestExtensionType.java:
##########
@@ -342,6 +347,34 @@ public void set(int index, UUID uuid) {
bb.putLong(uuid.getLeastSignificantBits());
getUnderlyingVector().set(index, bb.array());
}
+
+ @Override
+ public TransferPair makeTransferPair(ValueVector to) {
Review Comment:
This `TransferPair` is likely a very common pattern for extension types, so
one could create a concrete `ExtensionWriter` which actually implements this
and something like `UuidWriter` could inherit from.
We do something similar for our writers:
https://github.com/xtdb/xtdb/blob/e9a15ee12244367c1d3d1a75c00e4f5c0e10008f/core/src/main/kotlin/xtdb/vector/extensions/XtExtensionVector.kt#L30-L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
