Dandandan commented on a change in pull request #9551:
URL: https://github.com/apache/arrow/pull/9551#discussion_r581421495
##########
File path: rust/datafusion/src/physical_plan/functions.rs
##########
@@ -171,44 +180,51 @@ impl FromStr for BuiltinScalarFunction {
type Err = DataFusionError;
fn from_str(name: &str) -> Result<BuiltinScalarFunction> {
Ok(match name {
- "sqrt" => BuiltinScalarFunction::Sqrt,
- "sin" => BuiltinScalarFunction::Sin,
- "cos" => BuiltinScalarFunction::Cos,
- "tan" => BuiltinScalarFunction::Tan,
- "asin" => BuiltinScalarFunction::Asin,
+ // math functions
+ "abs" => BuiltinScalarFunction::Abs,
"acos" => BuiltinScalarFunction::Acos,
+ "asin" => BuiltinScalarFunction::Asin,
"atan" => BuiltinScalarFunction::Atan,
+ "ceil" => BuiltinScalarFunction::Ceil,
+ "cos" => BuiltinScalarFunction::Cos,
"exp" => BuiltinScalarFunction::Exp,
+ "floor" => BuiltinScalarFunction::Floor,
"log" => BuiltinScalarFunction::Log,
- "log2" => BuiltinScalarFunction::Log2,
"log10" => BuiltinScalarFunction::Log10,
- "floor" => BuiltinScalarFunction::Floor,
- "ceil" => BuiltinScalarFunction::Ceil,
+ "log2" => BuiltinScalarFunction::Log2,
"round" => BuiltinScalarFunction::Round,
- "truc" => BuiltinScalarFunction::Trunc,
- "abs" => BuiltinScalarFunction::Abs,
"signum" => BuiltinScalarFunction::Signum,
+ "sin" => BuiltinScalarFunction::Sin,
+ "sqrt" => BuiltinScalarFunction::Sqrt,
+ "tan" => BuiltinScalarFunction::Tan,
+ "trunc" => BuiltinScalarFunction::Trunc,
+
+ // string functions
+ "array" => BuiltinScalarFunction::Array,
+ "bit_length" => BuiltinScalarFunction::BitLength,
+ "btrim" => BuiltinScalarFunction::Btrim,
+ "char_length" => BuiltinScalarFunction::CharacterLength,
+ "character_length" => BuiltinScalarFunction::CharacterLength,
+ "concat_ws" => BuiltinScalarFunction::ConcatWithSeparator,
Review comment:
Alphabetically, this should be after `concat`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
