kou commented on code in PR #41837: URL: https://github.com/apache/arrow/pull/41837#discussion_r1615442491
########## java/dataset/src/main/cpp/jni_wrapper.cc: ########## @@ -27,7 +27,9 @@ #include "arrow/dataset/file_base.h" #include "arrow/filesystem/localfs.h" #include "arrow/filesystem/path_util.h" +#ifdef ARROW_S3 Review Comment: If we want to keep the current style, we need to include `arrow/util/config.h` explicitly before we use `ARROW_S3`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org