ianmcook commented on a change in pull request #9521:
URL: https://github.com/apache/arrow/pull/9521#discussion_r581537939
##########
File path: r/R/dplyr.R
##########
@@ -309,8 +344,27 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
# See dataset.R for Dataset and Scanner(Builder) classes
Review comment:
I'm going to open a dplyr PR suggesting that the `compute()` generic
should lose its required `name` argument. That `name` argument is a vestige
from the old days before dbplyr was broken out as a separate package, and it
does nothing AFAICT because every dplyr SQL backend package would use
`dbplyr::compute.tbl_sql()` (which redefines the `name` argument) or would
define its own `compute()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
