bkietz commented on a change in pull request #9532:
URL: https://github.com/apache/arrow/pull/9532#discussion_r582114128
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -50,26 +50,16 @@ struct ARROW_DS_EXPORT ScanContext {
std::shared_ptr<internal::TaskGroup> TaskGroup() const;
};
-class ARROW_DS_EXPORT ScanOptions {
- public:
- virtual ~ScanOptions() = default;
-
- static std::shared_ptr<ScanOptions> Make(std::shared_ptr<Schema> schema) {
- return std::shared_ptr<ScanOptions>(new ScanOptions(std::move(schema)));
- }
-
- // Construct a copy of these options with a different schema.
- // The projector will be reconstructed.
- std::shared_ptr<ScanOptions> ReplaceSchema(std::shared_ptr<Schema> schema)
const;
-
- // Filter
+struct ARROW_DS_EXPORT ScanOptions {
+ // Filter and projection
Expression filter = literal(true);
+ Expression projection;
- // Schema to which record batches will be reconciled
- const std::shared_ptr<Schema>& schema() const { return projector.schema(); }
+ // Schema with which batches will be read from disk
Review comment:
That is better, will replace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
