llama90 commented on PR #41827: URL: https://github.com/apache/arrow/pull/41827#issuecomment-2145252898
@felipecrv Thank you for your review. The main reason for handling this issue is to address the following problem: - #35560 I have implemented `Cast` Kernels for the necessary types. And I wanted to tackle the next issue to finally remove the `Scalar::CastTo` function: - #39182 However, I encountered a problem (such as in https://github.com/apache/arrow/pull/39192#discussion_r1477056138) where various languages binding C++ produced errors (e.g., Python, Ruby). Recently, I found a hint that implementing the `${TYPES}` to String Cast Kernel could solve the issue while trying to fix the recent problems again. As you mentioned, the long-term aspect of `"something for humans to read? JSON-like notation?"` is important, but the primary problem I wanted to solve was to remove the `Scalar::CastTo` function while maintaining compatibility with the existing code. For example, the `Scalar::ToString` function used `CastTo(utf8())` to handle `ToString()`, and I thought I could solve this by implementing the `Cast` Kernel for String Type. This is why I attempted to create these kernels. https://github.com/apache/arrow/blob/54bece3d4cf28df3e7bd92ed27f62d705a5cac96/cpp/src/arrow/scalar.cc#L978-L996 Thank you again for the in-depth review. I feel a bit overwhelmed about how to proceed. Solving new issues is important, but I also want to finish the PRs I have already submitted. It feels like I'm not making much progress. Anyway, I will think more about it based on your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
