CurtHagenlocher commented on code in PR #1895:
URL: https://github.com/apache/arrow-adbc/pull/1895#discussion_r1624665623
##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -38,7 +38,7 @@ namespace Apache.Arrow.Adbc.Drivers.Apache.Spark
{
public class SparkConnection : HiveServer2Connection
{
- const string UserAgent = "MicrosoftSparkODBCDriver/2.7.6.1014";
+ private readonly string UserAgent = $"{InfoDriverName.Replace(" ",
"")}/{ProductVersionDefault}";
Review Comment:
Note that some servers actually change their behavior based on the reported
client version -- Snowflake definitely does this -- so while this change is
right in principle it may have consequences in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
