jorisvandenbossche commented on code in PR #41972:
URL: https://github.com/apache/arrow/pull/41972#discussion_r1629377802
##########
python/pyarrow/_s3fs.pyx:
##########
@@ -237,11 +237,20 @@ cdef class S3FileSystem(FileSystem):
'port': 8020, 'username': 'username',
'password': 'password'})
allow_bucket_creation : bool, default False
- Whether to allow CreateDir at the bucket-level. This option may also be
+ Whether to allow directory creation at the bucket-level. This option
may also be
passed in a URI query parameter.
allow_bucket_deletion : bool, default False
- Whether to allow DeleteDir at the bucket-level. This option may also be
+ Whether to allow directory deletion at the bucket-level. This option
may also be
passed in a URI query parameter.
+ check_directory_existence_before_creation : bool, default false
+ Whether to check the directory existence before creating it.
+ if false, when creating a directory the code will not check if it
already
+ exists or not. It's an optimization to try directory creation and
catch the error,
+ rather than issue two dependent I/O calls.
Review Comment:
```suggestion
If false, when creating a directory the code will not check if it
already
exists or not. It's an optimization to try directory creation and
catch the error,
rather than issue two dependent I/O calls.
```
##########
python/pyarrow/_s3fs.pyx:
##########
@@ -237,11 +237,20 @@ cdef class S3FileSystem(FileSystem):
'port': 8020, 'username': 'username',
'password': 'password'})
allow_bucket_creation : bool, default False
- Whether to allow CreateDir at the bucket-level. This option may also be
+ Whether to allow directory creation at the bucket-level. This option
may also be
passed in a URI query parameter.
allow_bucket_deletion : bool, default False
- Whether to allow DeleteDir at the bucket-level. This option may also be
+ Whether to allow directory deletion at the bucket-level. This option
may also be
passed in a URI query parameter.
+ check_directory_existence_before_creation : bool, default false
+ Whether to check the directory existence before creating it.
+ if false, when creating a directory the code will not check if it
already
+ exists or not. It's an optimization to try directory creation and
catch the error,
+ rather than issue two dependent I/O calls.
+ if true, when creating a directory the code will only create the
directory when necessary
Review Comment:
```suggestion
If true, when creating a directory the code will only create the
directory when necessary
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]