WillAyd commented on code in PR #511:
URL: https://github.com/apache/arrow-nanoarrow/pull/511#discussion_r1633505054
##########
ci/scripts/coverage.sh:
##########
@@ -81,11 +81,12 @@ function main() {
# Build + run tests with gcov for IPC extension
show_header "Build + test nanoarrow_ipc"
- mkdir "${SANDBOX_DIR}/nanoarrow_ipc"
- pushd "${SANDBOX_DIR}/nanoarrow_ipc"
+ rm -rf "${SANDBOX_DIR}/nanoarrow"
+ mkdir "${SANDBOX_DIR}/nanoarrow"
+ pushd "${SANDBOX_DIR}/nanoarrow"
- cmake "${TARGET_NANOARROW_DIR}/extensions/nanoarrow_ipc" \
- -DNANOARROW_IPC_BUILD_TESTS=ON -DNANOARROW_IPC_CODE_COVERAGE=ON
+ cmake "${TARGET_NANOARROW_DIR}" \
+ -DNANOARROW_IPC=ON -DNANOARROW_BUILD_TESTS=ON
-DNANOARROW_CODE_COVERAGE=ON
Review Comment:
Not at all - just kept as separate steps owing to the history, but happy to
consolidate this into the existing "core" check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
