mapleFU commented on code in PR #42094:
URL: https://github.com/apache/arrow/pull/42094#discussion_r1634331146
##########
cpp/src/arrow/result.h:
##########
@@ -288,7 +288,7 @@ class [[nodiscard]] Result : public
util::EqualityComparable<Result<T>> {
constexpr bool ok() const { return status_.ok(); }
/// \brief Equivalent to ok().
- // operator bool() const { return ok(); }
+ constexpr explicit operator bool() const { return ok(); }
Review Comment:
This patch LGTM, but considering
https://github.com/apache/arrow/pull/4501#discussion_r293686808 . I'll let
other decide whether we applying this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
