tustvold commented on code in PR #5858:
URL: https://github.com/apache/arrow-rs/pull/5858#discussion_r1634820653
##########
arrow-row/src/fixed.rs:
##########
@@ -216,14 +216,80 @@ where
///
/// - 1 byte `0` if null or `1` if valid
/// - bytes of [`FixedLengthEncoding`]
-pub fn encode<T: FixedLengthEncoding, I: IntoIterator<Item = Option<T>>>(
+pub fn encode<T: ArrowPrimitiveType>(
data: &mut [u8],
offsets: &mut [usize],
- i: I,
+ array: &PrimitiveArray<T>,
+ opts: SortOptions,
+) where
+ T::Native: FixedLengthEncoding,
+{
+ let mut offset_idx = 1;
+ for maybe_val in array {
+ let offset = &mut offsets[offset_idx];
+ let end_offset = *offset + T::Native::ENCODED_LEN;
+ if let Some(val) = maybe_val {
+ let to_write = &mut data[*offset..end_offset];
+ to_write[0] = 1;
+ let mut encoded = val.encode();
+ if opts.descending {
+ // Flip bits to reverse order
+ encoded.as_mut().iter_mut().for_each(|v| *v = !*v)
+ }
+ to_write[1..].copy_from_slice(encoded.as_ref())
+ } else {
+ data[*offset] = null_sentinel(opts);
+ }
+ *offset = end_offset;
+ offset_idx += 1;
+ }
+}
+
+/// Encoding for non-nullable primitive arrays.
+/// Iterates directly over the `values`, and skips NULLs-checking.
+pub fn encode_not_null<T: ArrowPrimitiveType>(
+ data: &mut [u8],
+ offsets: &mut [usize],
+ array: &PrimitiveArray<T>,
+ opts: SortOptions,
+) where
+ T::Native: FixedLengthEncoding,
+{
+ assert!(!array.is_nullable());
+
+ let mut offset_idx = 1;
+ for val in array.values() {
+ let offset = &mut offsets[offset_idx];
+ let end_offset = *offset + T::Native::ENCODED_LEN;
+
+ let to_write = &mut data[*offset..end_offset];
+ to_write[0] = 1;
+ let mut encoded = val.encode();
+ if opts.descending {
Review Comment:
Perhaps LLVM is smart enough, but it might be interesting to see if pulling
this out of the loop improves performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
