ZhangHuiGui commented on PR #41234:
URL: https://github.com/apache/arrow/pull/41234#issuecomment-2164976474

   > > We will make decisions automatically internal and use a mode with better 
performance.
   > 
   > I'm not sure I understand. Do you mean you'll remove the option in a later 
PR?
   > 
   > Also, this PR claims to both fix a bug _and_ add an option. Can those two 
changes be made separate PRs?
   
   In this PR, this option will not be exposed to users, but only as an 
internal option of `RowTableMetadata`, this option will be used for internal 
functions(`RowTable` related or `CompareColumnsToRows`), it will be 
automatically set when initializing `RowTableMetadata` according to the order 
of columns entered by the user.
   
   There are two purposes for adding this option:
   1. It can improve performance in some scenarios
   2. Fix the bug in current PR's issue (and the fix of this bug depends on the 
existence of this option), so it's unnecessary to separate PRs.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to