emkornfield opened a new pull request #9582: URL: https://github.com/apache/arrow/pull/9582
The prior logic, I don't think is ever correct for signed comparison. Signed comparison of bytes as far as I can tell from the specification is only used by Decimal encoded values. Decimals are always encoded as big-endian two's complement integers. The new logic reflects this by doing sign extension when necessary for comparisons, and only using signed byte comparison for the very first value when appropriate. This PR also eliminates what appears to be a some dead code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
