kou commented on code in PR #42174:
URL: https://github.com/apache/arrow/pull/42174#discussion_r1643434588


##########
cpp/tools/parquet/CMakeLists.txt:
##########
@@ -31,6 +31,7 @@ if(PARQUET_BUILD_EXECUTABLES)
     install(TARGETS ${TOOL} ${INSTALL_IS_OPTIONAL}
             RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
   endforeach(TOOL)
+  target_link_libraries(parquet-dump-footer thrift)

Review Comment:
   Could you use `thrift::thrift` as the CMake target name for Apache Thrift?
   
   ```suggestion
     target_link_libraries(parquet-dump-footer thrift::thrift)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to