jonkeane commented on code in PR #42210:
URL: https://github.com/apache/arrow/pull/42210#discussion_r1647508460
##########
r/tools/nixlibs.R:
##########
@@ -574,6 +574,8 @@ build_libarrow <- function(src_dir, dst_dir) {
env_var_list <- c(env_var_list, setNames("BUNDLED", env_var))
}
}
+ # We also _do_ want to enable S3, GCS, and ZSTD by default
+ env_var_list <- c(env_var_list, c(ARROW_S3 = "ON", ARROW_GCS = "ON",
ARROW_WITH_ZSTD = "ON"))
Review Comment:
Ah, yes good catch
##########
r/tools/nixlibs.R:
##########
@@ -814,8 +816,14 @@ set_thirdparty_urls <- function(env_var_list) {
env_var_list
}
-is_feature_requested <- function(env_varname, default =
env_is("LIBARROW_MINIMAL", "false")) {
- env_value <- tolower(Sys.getenv(env_varname))
+is_feature_requested <- function(env_varname, env_var_list, default =
env_is("LIBARROW_MINIMAL", "false")) {
+ # look in our env_var_list first, if it's not found there go to
+ # the actual environment
+ env_value <- tolower(env_var_list[[env_varname]])
+ if (is.null(env_value)) {
+ env_value <- tolower(Sys.getenv(env_varname))
+ }
Review Comment:
AAAAH I was missing the `user-` part there, that makes it make more sense
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
