zanmato1984 commented on code in PR #42188:
URL: https://github.com/apache/arrow/pull/42188#discussion_r1650977600
##########
cpp/src/arrow/compute/row/compare_internal_avx2.cc:
##########
@@ -236,6 +236,8 @@ uint32_t KeyCompare::CompareBinaryColumnToRowHelper_avx2(
irow_right =
_mm256_loadu_si256(reinterpret_cast<const
__m256i*>(left_to_right_map) + i);
}
+ // TODO: Need to test if this gather is OK when irow_right is larger than
Review Comment:
I'll test in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
