rok commented on code in PR #42169:
URL: https://github.com/apache/arrow/pull/42169#discussion_r1653307913
##########
python/pyarrow/_parquet.pyx:
##########
@@ -1941,6 +1943,14 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
"'use_byte_stream_split' cannot be passed"
"together with 'column_encoding'")
+ # store_decimal_as_integer
+
+ if isinstance(store_decimal_as_integer, bool):
Review Comment:
Do we expect `store_decimal_as_integer` to ever not be a list of columns
like `use_byte_stream_split` can be above? If not we don't need this check.
##########
python/pyarrow/_parquet.pyx:
##########
@@ -1941,6 +1943,14 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
"'use_byte_stream_split' cannot be passed"
"together with 'column_encoding'")
+ # store_decimal_as_integer
+
+ if isinstance(store_decimal_as_integer, bool):
Review Comment:
In that case do we need to check if it's a boolean or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
