kou commented on PR #43117:
URL: https://github.com/apache/arrow/pull/43117#issuecomment-2204676946

   Could you fix lint failures?
   
   
https://github.com/apache/arrow/actions/runs/9760275633/job/26955306166?pr=43117#step:5:150
   
   ```text
   $ eslint src test
   
   /build/js/src/type.ts
     492:132  error  Missing semicolon  @typescript-eslint/semi
   
   /build/js/src/util/buffer.ts
     134:18  warning  Move generator function 'wrap' to the outer scope        
unicorn/consistent-function-scoping
     172:18  warning  Move async generator function 'wrap' to the outer scope  
unicorn/consistent-function-scoping
   
   /build/js/test/generate-test-data.ts
     327:5   warning  Unnecessarily cloning an array  unicorn/no-useless-spread
     349:5   warning  Unnecessarily cloning an array  unicorn/no-useless-spread
     370:20  warning  Unnecessarily cloning an array  unicorn/no-useless-spread
     380:20  warning  Unnecessarily cloning an array  unicorn/no-useless-spread
     488:51  warning  Unnecessarily cloning an array  unicorn/no-useless-spread
     626:49  warning  Unnecessarily cloning an array  unicorn/no-useless-spread
   
   /build/js/test/unit/vector/interval-month-day-nano-tests.ts
      1:56  error  Strings must use singlequote                                 
@typescript-eslint/quotes
      6:25  error  Expected a semicolon                                         
@typescript-eslint/member-delimiter-style
     16:5   error  This `if` statement can be replaced by a ternary expression  
unicorn/prefer-ternary
     28:42  error  Missing semicolon                                            
@typescript-eslint/semi
     39:5   error  Use a `for-of` loop instead of this `for` loop               
unicorn/no-for-loop
     41:9   error  Use a `for-of` loop instead of this `for` loop               
unicorn/no-for-loop
     84:4   error  Newline required at end of file but not found                
eol-last
   
   ✖ 16 problems (8 errors, 8 warnings)
     8 errors and 0 warnings potentially fixable with the `--fix` option.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to