mapleFU commented on code in PR #41580:
URL: https://github.com/apache/arrow/pull/41580#discussion_r1664379656
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1104,6 +1106,7 @@ int64_t ColumnWriterImpl::Close() {
if (rows_written_ > 0 && chunk_statistics.is_set()) {
metadata_->SetStatistics(chunk_statistics);
}
+ metadata_->SetKeyValueMetadata(std::move(key_value_metadata_));
Review Comment:
🤔 should we not move metadata in to help some debugging?
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1104,6 +1106,7 @@ int64_t ColumnWriterImpl::Close() {
if (rows_written_ > 0 && chunk_statistics.is_set()) {
metadata_->SetStatistics(chunk_statistics);
}
+ metadata_->SetKeyValueMetadata(std::move(key_value_metadata_));
Review Comment:
🤔 should we not move metadata in to leave some context and help some
debugging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
