danepitkin commented on code in PR #43139:
URL: https://github.com/apache/arrow/pull/43139#discussion_r1670897560
##########
java/flight/flight-core/pom.xml:
##########
@@ -175,6 +177,13 @@ under the License.
<include>com.google.protobuf:*</include>
</includes>
</artifactSet>
+ <filters>
+ <filter>
+ <excludes>
+ <exclude>**/module-info.class</exclude>
Review Comment:
I think a separate pull request for shaded artifacts is okay. We should also
get rid of the warning I pasted initially before releasing v18. Someone on the
original GH issue recommended using shading to prevent us from exposing those
module names. Maybe that can be a separate issue, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]